Request a Demo
Home   >   mailing lists

Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint()
Date
Msg-id ainhybfghL6I5Ek2@paquier.xyz
Whole thread
In response to Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint()  (Andres Freund <andres@anarazel.de>)
Responses Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint()
List pgsql-hackers
Tree view 
On Wed, Jun 10, 2026 at 10:36:22AM -0400, Andres Freund wrote:
> I think it *should* blow up. It doesn't because we're lacking assertions in
> GetBufferDescriptor(). But I don't think the assertions added in the patch are
> quite right.
>
> We can't trivially add the correct assertions, because somebody though it was
> a good idea to give GetBufferDescriptor() a uint32 parameter, which seems
> completely wrong to me.

This one is not as old as I expected: 3ac88fddd92c.  You're right that
switching that to be signed would be a correct first step forward.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: [PATCH v5] pg_stat_statements: Add last_execution_start column
Next
From: Michael Paquier
Date:
Subject: Re: Fix unqualified catalog references in psql describe queries