Re: vectorized CRC on ARM64 - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: vectorized CRC on ARM64
Date
Msg-id adEiCi5gHvN4XTp-@nathan
Whole thread Raw
In response to Re: vectorized CRC on ARM64  (John Naylor <johncnaylorls@gmail.com>)
Responses Re: vectorized CRC on ARM64
List pgsql-hackers
On Sat, Apr 04, 2026 at 08:52:34PM +0700, John Naylor wrote:
> Thanks for looking! Pushed with a minor comment tweak and removal of
> the CFLAGS save-and-restore dance since we don't need it anymore.
> Let's see what the buildfarm thinks.

Ha, I think koel is going to complain about your comment that talks about
pgindent...

diff --git a/src/port/pg_crc32c_armv8.c b/src/port/pg_crc32c_armv8.c
index b404e6c373e..5fa57fb4927 100644
--- a/src/port/pg_crc32c_armv8.c
+++ b/src/port/pg_crc32c_armv8.c
@@ -162,8 +162,8 @@ pg_comp_crc32c_pmull(pg_crc32c crc, const void *data, size_t len)
         }

         /*
-         * pgindent complained of unmatched parens, so the following has
-         * been re-written with intrinsics:
+         * pgindent complained of unmatched parens, so the following has been
+         * re-written with intrinsics:
          *
          * x0 = veorq_u64((uint64x2_t) {crc0, 0}, x0);
          */

-- 
nathan



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Add pg_stat_autovacuum_priority
Next
From: Tom Lane
Date:
Subject: Re: TupleDescAttr bounds checks