Re: Consistently use the XLogRecPtrIsInvalid() macro - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Consistently use the XLogRecPtrIsInvalid() macro
Date
Msg-id ac6006ac-7d7b-42d3-8688-91afdfd39467@eisentraut.org
Whole thread Raw
In response to Re: Consistently use the XLogRecPtrIsInvalid() macro  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On 01.12.25 08:14, Bertrand Drouvot wrote:
> Hi,
> 
> On Tue, Nov 18, 2025 at 04:54:32PM +0100, Peter Eisentraut wrote:
>> I mean, some people like writing if (!foo) and some like writing if
>> (foo == NULL), but we're not going to legislate one
>> over the other.
> 
> Agree. Out of curiosity, I searched for pointers and literal zero comparisons
> or assignments (with [1]) and found 6 of them.
> 
> While literal zero is technically correct, NULL is the semantically appropriate
> choice for pointers.
> 
> PFA a patch to fix those 6.

committed (required pgindent)




pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Remove useless pointer advance in StatsShmemInit()
Next
From: jian he
Date:
Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions