Re: Consistently use the XLogRecPtrIsInvalid() macro - Mailing list pgsql-hackers

Hi,

On Tue, Nov 18, 2025 at 04:54:32PM +0100, Peter Eisentraut wrote:
> I mean, some people like writing if (!foo) and some like writing if
> (foo == NULL), but we're not going to legislate one
> over the other.

Agree. Out of curiosity, I searched for pointers and literal zero comparisons
or assignments (with [1]) and found 6 of them.

While literal zero is technically correct, NULL is the semantically appropriate
choice for pointers.

PFA a patch to fix those 6.

[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/misc/pointers_and_literal_zero.cocci

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com