Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode
Date
Msg-id ac58d025-ec1c-34d0-dfcd-27a86b5b873b@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 7/9/17 22:08, Michael Paquier wrote:
> While the version on my laptop does that:
>         if (time_to_abort)
>         {
> -               fprintf(stderr, _("%s: received interrupt signal, exiting\n"),
> -                               progname);
> +               if (verbose)
> +                       fprintf(stderr, _("%s: received interrupt
> signal, exiting\n"),
> +                                       progname);
>                 return true;
>         }
>         return false;
> Not sure how that feel into the cracks.

I have committed that version.  I think the exit message can be useful,
because pg_receivewal will usually run as some kind of background
process where the exit status might be not be visible.

I have also committed a small documentation patch to describe the exit
status and behavior better.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] POC: Sharing record typmods between backends