Hi,
On Thu, Mar 12, 2026 at 11:10:51AM -0400, Tom Lane wrote:
> Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> > On Wed, Mar 11, 2026 at 01:48:31PM -0400, Andres Freund wrote:
> >> On 2026-03-11 12:45:55 -0400, Tom Lane wrote:
> >>> So no, I don't wanna support this. But maybe we should move the
> >>> code-level tests out of the datetime files and into utils/float.h
> >>> or some such place.
>
> >> I think it's probably better to have it in a .c file (maybe float.c), I could
> >> kinda imagine some extension intentionally enabling -ffast-math, because it
> >> does something numerically intensive where the incorrectness doesn't matter.
>
> > I think that you have a good point about the extension. That said a .h file
> > could also prevent the extension to make use of -ffast-math "accidentally".
>
> Yeah, that was my thought too. But I think Andres has a point that in
> principle an extension could use -ffast-math intentionally, so I'm
> content to just put the test in float.c.
Yeah, I do agree. Something like in the attached?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
