Re: Make copyObject work in C++ - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Make copyObject work in C++
Date
Msg-id CAGECzQR6xzM_qO8wOqK36uLpE9KknKw0P2=+FbPf8KOQxjGZWQ@mail.gmail.com
Whole thread
In response to Re: Make copyObject work in C++  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On Mon, 9 Mar 2026 at 09:39, Peter Eisentraut <peter@eisentraut.org> wrote:
> I think we should really work to
> get rid of __builtin_types_compatible_p() and replace it with _Generic,
> which would be portable beyond GCC.

I initially intended to do this, but sadly using _Generic inside our
static assert constructs (even the new version you added) causes
internal compiler errors on MSVC 19... I agree with your other
feedback, and I think it's probably best to retract this patch (I've
marked it as committeed in the commitfest now, because of all the
other patches). The main reason I cared about this was to have a
_Generic based macro for type comparisons, which I could use in other
patches. I'll just create some there instead.



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Add missing stats_reset column to pg_stat_database_conflicts view
Next
From: Bertrand Drouvot
Date:
Subject: Re: Defend against -ffast-math in meson builds