Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Date
Msg-id aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net
Whole thread Raw
In response to Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On 10/8/21 11:41 AM, Andrew Dunstan wrote:
> On 10/1/21 6:34 PM, Andres Freund wrote:
>> Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
>>
>> The previous approach didn't really work on windows, due to the PATH separator
>> being ';' not ':'. Instead of making the PATH change more complicated,
>> reference the binary using the TESTDIR environment.
>>
>> Reported-By: Andres Freund <andres@anarazel.de>
>> Suggested-By: Andrew Dunstan <andrew@dunslane.net>
>> Discussion: https://postgr.es/m/20210930214040.odkdd42vknvzifm6@alap3.anarazel.de
>> Backpatch: 14-, where the test was introduced.
>>
> I don't think any of us were thinking very clearly about this. Of
> course, MSVC doesn't build executables in $TESTDIR. If we want to pick
> up the executable from where it's built we'll need a little help from
> vcregress.pl. I haven't tested it but What I have in mind is something
> like the attached.
>
>

Confirmed that this makes the test pass.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.