Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command - Mailing list pgsql-bugs

From Peter Eisentraut
Subject Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command
Date
Msg-id aa186eac-2701-210a-bbf1-3e1bec945e23@enterprisedb.com
Whole thread Raw
In response to Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-bugs
On 20.08.21 12:49, Daniel Gustafsson wrote:
>> On 19 Aug 2021, at 04:45, Julien Rouhaud <rjuju123@gmail.com> wrote:
>>
>> On Thu, Aug 19, 2021 at 2:53 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>>
>>>> On 18 Aug 2021, at 15:49, Daniel Gustafsson <daniel@yesql.se> wrote:
>>>>
>>>> Since there is consensus for removing --quiet, I’ll propose a patch in a bit
>>>> for removing it and fixing up the tests.
>>>
>>> Turns I was a bit undercaffeinated when skimming the tests, it really wasn’t
>>> that invasive.  The attached diff removes --quiet and fixes up the tests and
>>> docs to match.  Anyone who wants to keep --quiet should..  ehm, not keep quiet.
>>
>> The patch looks good to me.
> 
> Applied to master and 14, thanks for review!

I see that we still have the PQsetErrorVerbosity() call for --verbose, 
and we still issue warnings with --no-strict-names.  Did we want to keep 
these two behaviors?



pgsql-bugs by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: BUG #17158: Distinct ROW fails with Postgres 14
Next
From: Daniel Gustafsson
Date:
Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command