Re: Flush some statistics within running transactions - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Flush some statistics within running transactions
Date
Msg-id aXJUK90lKXw3wrZn@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Flush some statistics within running transactions  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Flush some statistics within running transactions
List pgsql-hackers
Hi,

On Thu, Jan 22, 2026 at 09:12:18PM +0900, Fujii Masao wrote:
> On Thu, Jan 22, 2026 at 4:43 PM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> >
> > pgstat_report_anytime_stat() is called with the force parameter set to false,
> > means that the flushes are done with nowait = true means that LWLockConditionalAcquire()
> > is used. In that case, do you still see cases where log_lock_waits messages could
> > be triggered due to the new flush?
> 
> I haven't read the patch in detail yet, but after applying patch 0001 and
> causing a lock wait (for example, using the steps below), I observed that
> log_lock_waits messages are emitted every second.
> 
>     [session 1]
>     create table tbl as select id from generate_series(1, 10) id;
>     begin;
>     select * from tbl where id = 1 for update;
> 
>     [session 2]
>     begin;
>     select * from tbl where id = 1 for update;
> 
> With this setup, the following messages were logged once per second:
> 
>     LOG:  process 72199 still waiting for ShareLock on transaction 771
> after 63034.119 ms
>     DETAIL:  Process holding the lock: 72190. Wait queue: 72199.
> 

Thanks!

I see, the WaitLatch() in ProcSleep() is "woken up" every 1s due to the 
enable_timeout_after(ANYTIME_STATS_UPDATE_TIMEOUT,...) being set unconditionally
in ProcessInterrupts(). We need to be more restrictive as to when to enable the
timeout, I'll fix in the next version.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Fix rounding method used to compute huge pages
Next
From: Andres Freund
Date:
Subject: Re: ReadRecentBuffer() doesn't scale well