Fix rounding method used to compute huge pages - Mailing list pgsql-hackers

From Anthonin Bonnefoy
Subject Fix rounding method used to compute huge pages
Date
Msg-id CAO6_Xqq2vZbva0R9eQSY0p2kfksX2aP4r=+Z_q1HBYNU=m8bBg@mail.gmail.com
Whole thread Raw
Responses Re: Fix rounding method used to compute huge pages
Re: Fix rounding method used to compute huge pages
List pgsql-hackers
Hi,

When computing the dynamic value of shared_memory_size_in_huge_pages,
(1+size_b/hp_size) is currently used. This works when size_b is not
divisible by hp_size. However, it will yield an additional huge page
when size_b is divisible by hp_size.

On CreateAnonymousSegment's side, the allocation size is rounded up to
the next required huge pages when necessary. However, there's no
overflow check when doing this round up.

0001: This patch replicates CreateAnonymousSegment's rounding method
to InitializeShmemGUCs, only rounding up when the value is not
divisible by hp_size.

0002: This patch uses add_size in CreateAnonymousSegment when the
allocation size is rounded up, to check for possible overflow.

Regards,
Anthonin Bonnefoy

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Mystery with REVOKE PRIVILEGE
Next
From: Bertrand Drouvot
Date:
Subject: Re: Flush some statistics within running transactions