Re: pg_stat_statements: add missing tests for nesting_level - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_stat_statements: add missing tests for nesting_level
Date
Msg-id aXAg1zOSQmmdhazO@paquier.xyz
Whole thread Raw
In response to pg_stat_statements: add missing tests for nesting_level  (Sami Imseih <samimseih@gmail.com>)
Responses Re: pg_stat_statements: add missing tests for nesting_level
List pgsql-hackers
On Tue, Jan 20, 2026 at 06:08:14PM -0600, Sami Imseih wrote:
> While looking at pg_stat_statements nesting_level, I realized that there
> are missing nesting_level tests for pgss_planner and pgss_ExecutorFinish.
> That is, if you remove nesting_level++ and nesting_level-- in those 2 hooks,
> the tests will still succeed.
>
> For pgss_planner the nesting_level updates missing tests are the ones
> when track_planning is enabled.
>
> Attached is a quick patch to add coverage.

Confirmed these two deficiencies, nice catch.  If one does the same
removal of the nesting level calculation in other code paths like
pgss_ExecutorRun(), one get complaints.  Will see to get this addition
done.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: pg_stat_statements: Fix nested tracking for implicitly closed cursors
Next
From: "David G. Johnston"
Date:
Subject: Re: docs: clarify ALTER TABLE behavior on partitioned tables