Request a Demo
Home   >   mailing lists

pg_stat_statements: add missing tests for nesting_level - Mailing list pgsql-hackers

From Sami Imseih
Subject pg_stat_statements: add missing tests for nesting_level
Date
Msg-id CAA5RZ0uK1PSrgf52bWCtDpzaqbWt04o6ZA7zBm6UQyv7vyvf9w@mail.gmail.com
Whole thread Raw
Responses Re: pg_stat_statements: add missing tests for nesting_level
List pgsql-hackers
Tree view 
Hi,

While looking at pg_stat_statements nesting_level, I realized that there
are missing nesting_level tests for pgss_planner and pgss_ExecutorFinish.
That is, if you remove nesting_level++ and nesting_level-- in those 2 hooks,
the tests will still succeed.

For pgss_planner the nesting_level updates missing tests are the ones
when track_planning is enabled.

Attached is a quick patch to add coverage.


--
Sami Imseih
Amazon Web Services (AWS)
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Extended Statistics set/restore/clear functions.
Next
From: Sami Imseih
Date:
Subject: Re: pg_stat_statements: Fix nested tracking for implicitly closed cursors