Request a Demo
Home   >   mailing lists

Re: Sequence Access Methods, round two - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Sequence Access Methods, round two
Date
Msg-id aUT_zfgDSMKj-LEo@paquier.xyz
Whole thread Raw
In response to Re: Sequence Access Methods, round two  (Xuneng Zhou <xunengzhou@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Dec 19, 2025 at 02:45:47PM +0800, Xuneng Zhou wrote:
> Thanks for working on this. I tried to review patch set v25, but I
> wasn’t able to apply it cleanly on HEAD.

Strange.  It rebases correctly even on today's HEAD at 5cdbec5aa9dc.

> We have two macros the same here.
>
> 2. Duplicate stmt->tableElts = NIL; in sequence.c:

It looks like I have fat-fingered some rebases here.

> Should we update this to "seq_local_redo: unknown op code %u”?

Yep, thanks.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: Fix typo 586/686 in atomics/arch-x86.h
Next
From: Masahiko Sawada
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart