Re: Fix typo 586/686 in atomics/arch-x86.h - Mailing list pgsql-hackers

From John Naylor
Subject Re: Fix typo 586/686 in atomics/arch-x86.h
Date
Msg-id CANWCAZZhAcjY+b-KCHX74YuDGL1ffS=vHr68UHH9CBXEn+weUg@mail.gmail.com
Whole thread Raw
In response to Re: Fix typo 586/686 in atomics/arch-x86.h  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Fix typo 586/686 in atomics/arch-x86.h
List pgsql-hackers
On Fri, Nov 28, 2025 at 4:00 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 28 Nov 2025, at 09:44, Jakub Wartak <jakub.wartak@enterprisedb.com> wrote:
> >
> > That's a typo in src/include/port/atomics/arch-x86.h, isn't it ?:
> >   if defined(__i568__) || defined(__i668__) || /* gcc i586+ */
> > If yes, then a patch is attached. Not that it harms something or
> > somebody has such old hardware, but I've just spotted it while looking
> > for something else.
>
> That indeed looks like a clear typo, but if noone has complained since 2017
> then maybe removing the checks is the right course of action?

I believe CI tests with -m32, so as long as we do that we should
probably make that work the way we think it does.

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Report bytes and transactions actually sent downtream
Next
From: Michael Paquier
Date:
Subject: Re: Sequence Access Methods, round two