Re: vacuumdb: add --dry-run - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: vacuumdb: add --dry-run
Date
Msg-id aR5IMz4cngn8hkXI@nathan
Whole thread Raw
In response to Re: vacuumdb: add --dry-run  (Corey Huinker <corey.huinker@gmail.com>)
Responses Re: vacuumdb: add --dry-run
List pgsql-hackers
On Wed, Nov 19, 2025 at 05:23:48PM -0500, Corey Huinker wrote:
> Now with zero hangs and some test cases. I didn't create a function (yet)
> as it seemed trivial.

I still think it could be worth moving the dry-run code into
run_vacuum_command() (which might entail moving the calls to
ParallelSlotSetHandler() there, too).  We can probably piggy-back on the
"if (echo)" branch in that function.

Also, we can probably skip the executeCommand() calls for
--analyze-in-stages.

-- 
nathan



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: PRI?64 vs Visual Studio (2022)
Next
From: Samuel Thibault
Date:
Subject: Re: GNU/Hurd portability patches