Re: vacuumdb: add --dry-run - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: vacuumdb: add --dry-run
Date
Msg-id CADkLM=dwBjL5fK-Dq_2qhAuHsHPab_Kt+R7KZTA9w_X0K6bENg@mail.gmail.com
Whole thread Raw
In response to Re: vacuumdb: add --dry-run  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: vacuumdb: add --dry-run
List pgsql-hackers
On Wed, Nov 19, 2025 at 5:44 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Wed, Nov 19, 2025 at 05:23:48PM -0500, Corey Huinker wrote:
> Now with zero hangs and some test cases. I didn't create a function (yet)
> as it seemed trivial.

I still think it could be worth moving the dry-run code into
run_vacuum_command() (which might entail moving the calls to
ParallelSlotSetHandler() there, too).  We can probably piggy-back on the
"if (echo)" branch in that function.

We _could_ get away with moving ParallelSlotGetIdle() in there too. The only catch would be that we'd have to refactor prepare_vacuum_command() to take a serverVersionNumber parameter instead of the whole connection. Thoughts?
 

Also, we can probably skip the executeCommand() calls for
--analyze-in-stages.

+1  

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: postgres_fdw: Use COPY to speed up batch inserts
Next
From: Chao Li
Date:
Subject: Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis