Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Date
Msg-id aPqPK4ERy5-jj185@nathan
Whole thread Raw
In response to Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Mon, Jun 23, 2025 at 01:42:32PM +0300, Aleksander Alekseev wrote:
>> Do we want to skip such comments?
>> I have also seen comments with '====' border.
> 
> Personally I don't have a strong opinion on this. We can easily add an
> exception for "/* ---" and "/* ===" comments if somebody believes this
> is a problem. I choose not to add such an exception just yet only
> because I don't like unnecessary exceptions :)

+1 for adding an exception for "/* -----" style comments.  I tested running
pgindent after applying the patch, and the first thing I noticed was all
these (IMHO) unnecessary changes.  I don't think it helps readability, and
even if it did, it's arguably not worth the churn.

-- 
nathan



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: another autovacuum scheduling thread
Next
From: Sami Imseih
Date:
Subject: Re: another autovacuum scheduling thread