Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Date
Msg-id CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
List pgsql-hackers
Hi Nathan,

> > Personally I don't have a strong opinion on this. We can easily add an
> > exception for "/* ---" and "/* ===" comments if somebody believes this
> > is a problem. I choose not to add such an exception just yet only
> > because I don't like unnecessary exceptions :)
>
> +1 for adding an exception for "/* -----" style comments.  I tested running
> pgindent after applying the patch, and the first thing I noticed was all
> these (IMHO) unnecessary changes.  I don't think it helps readability, and
> even if it did, it's arguably not worth the churn.

OK, here is the corrected patch v5.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Maxim Orlov
Date:
Subject: Re: AIO writes vs hint bits vs checksums
Next
From: Alexander Korotkov
Date:
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands