Re: Missing import in 035_standby_logical_decoding.pl - Mailing list pgsql-hackers

Hi,

On Fri, Aug 01, 2025 at 04:57:50PM -0400, Melanie Plageman wrote:
> On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
> >
> > 035_standby_logical_decoding.pl has this code
> 
> Another issue I see is that there are two incorrect tests for a log message
> 
> # message should not be issued
> ok( !$node_standby->log_contains(
>         "invalidating obsolete slot \"no_conflict_inactiveslot\"", $logstart),
>     'inactiveslot slot invalidation is not logged with vacuum on conflict_test'
> );
> 
> ok( !$node_standby->log_contains(
>         "invalidating obsolete slot \"no_conflict_activeslot\"", $logstart),
>     'activeslot slot invalidation is not logged with vacuum on conflict_test'
> );
> 
> This will never fail because the message string is actually
> "invalidating obsolete replication slot"
> 
> It is correctly specified elsewhere in the same test.
> so, that should be fixed too.

Thanks for the report! Indeed, fixed in 0001 just shared up-thread.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com