Re: Missing import in 035_standby_logical_decoding.pl - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Missing import in 035_standby_logical_decoding.pl
Date
Msg-id CAAKRu_a7gYu1M0LA0T6C0y54XOJRiYqkTZmrmewOfrik+uJ_uw@mail.gmail.com
Whole thread Raw
In response to Missing import in 035_standby_logical_decoding.pl  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: Missing import in 035_standby_logical_decoding.pl
List pgsql-hackers
On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> 035_standby_logical_decoding.pl has this code

Another issue I see is that there are two incorrect tests for a log message

# message should not be issued
ok( !$node_standby->log_contains(
        "invalidating obsolete slot \"no_conflict_inactiveslot\"", $logstart),
    'inactiveslot slot invalidation is not logged with vacuum on conflict_test'
);

ok( !$node_standby->log_contains(
        "invalidating obsolete slot \"no_conflict_activeslot\"", $logstart),
    'activeslot slot invalidation is not logged with vacuum on conflict_test'
);

This will never fail because the message string is actually
"invalidating obsolete replication slot"

It is correctly specified elsewhere in the same test.
so, that should be fixed too.

- Melanie



pgsql-hackers by date:

Previous
From: Alexander Borisov
Date:
Subject: Re: Improve the performance of Unicode Normalization Forms.
Next
From: Melanie Plageman
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)