On Fri, Aug 01, 2025 at 03:22:06PM -0700, Masahiko Sawada wrote:
> On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
>> Another issue I see is that there are two incorrect tests for a log message
>>
>> # message should not be issued
>> ok( !$node_standby->log_contains(
>> "invalidating obsolete slot \"no_conflict_inactiveslot\"", $logstart),
>> 'inactiveslot slot invalidation is not logged with vacuum on conflict_test'
>> );
>>
>> ok( !$node_standby->log_contains(
>> "invalidating obsolete slot \"no_conflict_activeslot\"", $logstart),
>> 'activeslot slot invalidation is not logged with vacuum on conflict_test'
>> );
>>
>> This will never fail because the message string is actually
>> "invalidating obsolete replication slot"
>>
>> It is correctly specified elsewhere in the same test.
>> so, that should be fixed too.
>
> +1
Not the author of these two ones, but am I the only one who does not
see the point of these two tests? These check that something does not
happen, but log_contains() is useful to make sure that an event
*actually happens*. Wouldn't it be simpler to remove these checks or
switch them to use/add a log message that's triggered with a state
that we'd expect to happen in reality?
--
Michael
