Downloads
Home   >   mailing lists

Re: [PATCH] Add tests for binaryheap.c - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: [PATCH] Add tests for binaryheap.c
Date
Msg-id aHf-tbrDaWJPGdTl@nathan
Whole thread Raw
In response to Re: [PATCH] Add tests for binaryheap.c  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: [PATCH] Add tests for binaryheap.c
List pgsql-hackers
Tree view 
On Fri, Jun 27, 2025 at 02:02:22PM +0300, Aleksander Alekseev wrote:
>> I'm not sure I see much point in testing both min-heaps and max-heaps.  The
>> only difference between the two is in the comparator, so IMHO the extra
>> tests really only serve to test the test comparator.
> 
> Make sense. Here is the corrected patch.

I trimmed this down some more while trying to keep the coverage the same.

-- 
nathan
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: index prefetching
Next
From: Tom Lane
Date:
Subject: Re: Fix PQport to never return NULL if the connection is valid