Downloads
Home   >   mailing lists

Re: [PATCH] Add tests for binaryheap.c - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: [PATCH] Add tests for binaryheap.c
Date
Msg-id aF2xurczhN0rS07L@nathan
Whole thread Raw
List pgsql-hackers
Tree view 
On Thu, Jun 26, 2025 at 06:16:10PM +0300, Aleksander Alekseev wrote:
> The proposed patch adds tests for binaryheap.c. This is similar to our
> tests for RB-trees in test_rbtree.c.

Adding some tests here seems like a good idea.

I'm not sure I see much point in testing both min-heaps and max-heaps.  The
only difference between the two is in the comparator, so IMHO the extra
tests really only serve to test the test comparator.

-- 
nathan

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main()
Next
From: Peter Eisentraut
Date:
Subject: Re: Adding support for SSLKEYLOGFILE in the frontend