On Wed, Jul 16, 2025 at 11:42:33AM +0100, Dean Rasheed wrote:
> Attached is a reproducer using the merge-match-recheck isolation test.
>
> I believe that the bug only goes back to v17, because MERGE could not
> appear inside a CTE prior to that.
That was fast, nice!
> I think that best thing to do is pass the commandType to
> ExecBRUpdateTriggers(), except that in v17 we shouldn't change the
> signature of ExecBRUpdateTriggers(), so a wrapper function will be
> needed, similar to what 9321c79 did.
Yes, changing ExecBRUpdateTriggers() would not be a good idea on a
stable branch.. I can see that at least timescaledb does a direct
call to it. A minor upgrade breakage would be bad for them.
> Question: Is it OK to change the signature of ExecBRUpdateTriggers()
> in v18?
We are still in beta, so that's not a problem for v18 and HEAD.
--
Michael
