Re: Consolidate ItemPointer to Datum conversion functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Consolidate ItemPointer to Datum conversion functions
Date
Msg-id a6a190a1-ec0b-6bcc-eb38-2aa5889bbd7d@enterprisedb.com
Whole thread Raw
In response to Re: Consolidate ItemPointer to Datum conversion functions  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On 09.02.23 09:33, Peter Eisentraut wrote:
> On 06.02.23 11:11, Heikki Linnakangas wrote:
>> On 06/02/2023 11:54, Peter Eisentraut wrote:
>>> Instead of defining the same set of macros several times, define it once
>>> in an appropriate header file.  In passing, convert to inline functions.
>>
>> Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and 
>> PG_RETURN_ITEMPOINTER, too? They're only used in tid.c, but for most 
>> datatypes, we define the PG_GETARG and PG_RETURN macros in the same 
>> header file as the the Datum conversion functions.
> 
> Yeah that makes sense.  Here is an updated patch for that.

committed



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Support logical replication of DDLs
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?