Re: Consolidate ItemPointer to Datum conversion functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Consolidate ItemPointer to Datum conversion functions
Date
Msg-id 5f6ed461-331f-47b5-9ce2-90fc660d78f5@enterprisedb.com
Whole thread Raw
In response to Re: Consolidate ItemPointer to Datum conversion functions  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Consolidate ItemPointer to Datum conversion functions
List pgsql-hackers
On 06.02.23 11:11, Heikki Linnakangas wrote:
> On 06/02/2023 11:54, Peter Eisentraut wrote:
>> Instead of defining the same set of macros several times, define it once
>> in an appropriate header file.  In passing, convert to inline functions.
> 
> Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and 
> PG_RETURN_ITEMPOINTER, too? They're only used in tid.c, but for most 
> datatypes, we define the PG_GETARG and PG_RETURN macros in the same 
> header file as the the Datum conversion functions.

Yeah that makes sense.  Here is an updated patch for that.

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Is psSocketPoll doing the right thing?
Next
From: Masahiko Sawada
Date:
Subject: Re: Exit walsender before confirming remote flush in logical replication