Postgres Pro
Downloads
Home   >   mailing lists

Re: Why does create_gather_merge_plan need make_sort? - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: Why does create_gather_merge_plan need make_sort?
Date
Msg-id a3fda974-fbfe-66b3-eeb8-5670a942098c@enterprisedb.com
Whole thread Raw
In response to Re: Why does create_gather_merge_plan need make_sort?  (James Coleman <jtc331@gmail.com>)
Responses Re: Why does create_gather_merge_plan need make_sort?
List pgsql-hackers
Tree view 

On 11/29/20 3:44 PM, James Coleman wrote:
> On Mon, Nov 23, 2020 at 8:19 AM James Coleman <jtc331@gmail.com> wrote:
>>
>> ..
>>
>> So I'm +1 on turning it into an ERROR log instead, since it seems to
>> me that encountering this case would almost certainly represent a bug
>> in path generation.
> 
> Here's a patch to do that.
>

Thanks. Isn't the comment incomplete? Should it mention just parallel
safety or also volatility?


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Additional improvements to extended statistics
Next
From: Tomas Vondra
Date:
Subject: Re: Fix generate_useful_gather_paths for parallel unsafe pathkeys