Re: Why does create_gather_merge_plan need make_sort? - Mailing list pgsql-hackers

From James Coleman
Subject Re: Why does create_gather_merge_plan need make_sort?
Date
Msg-id CAAaqYe_2KtTJaQ_7o6kjJFzmNu=hGTRPzV3BsZrNgGWg1vU0xA@mail.gmail.com
Whole thread Raw
In response to Re: Why does create_gather_merge_plan need make_sort?  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: Why does create_gather_merge_plan need make_sort?
List pgsql-hackers
On Sun, Nov 29, 2020 at 4:10 PM Tomas Vondra
<tomas.vondra@enterprisedb.com> wrote:
>
>
>
> On 11/29/20 3:44 PM, James Coleman wrote:
> > On Mon, Nov 23, 2020 at 8:19 AM James Coleman <jtc331@gmail.com> wrote:
> >>
> >> ..
> >>
> >> So I'm +1 on turning it into an ERROR log instead, since it seems to
> >> me that encountering this case would almost certainly represent a bug
> >> in path generation.
> >
> > Here's a patch to do that.
> >
>
> Thanks. Isn't the comment incomplete? Should it mention just parallel
> safety or also volatility?

Volatility makes it parallel unsafe, and I'm not sure I want to get
into listing every possible issue here, but in the interest of making
it more obviously representative of the kinds of issues we might
encounter, I've tweaked it to mention volatility also, as well as
refer to the issues as "examples" of such concerns.

James

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: remove spurious CREATE INDEX CONCURRENTLY wait
Next
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: Disable WAL logging to speed up data loading