Re: Incorrect comment in get_partition_dispatch_recurse - Mailing list pgsql-hackers

From Amit Langote
Subject Re: Incorrect comment in get_partition_dispatch_recurse
Date
Msg-id a2d585af-b6a7-4b96-c360-7ef0fba6eba4@lab.ntt.co.jp
Whole thread Raw
In response to Re: Incorrect comment in get_partition_dispatch_recurse  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Incorrect comment in get_partition_dispatch_recurse  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2018/05/18 5:56, David Rowley wrote:
> On 18 May 2018 at 06:21, Robert Haas <robertmhaas@gmail.com> wrote:
>> All right, so let's just say that explicitly.  Maybe something like
>> the attached.
> 
> That looks fine to me.

Me too, except:

+     * *pds list is the root partition, so 0 always means the first leaf. When

I prefer "root partitioned table" over "root partition", and git grep
suggests that that's actually what we use elsewhere in the source code.

Thanks,
Amit



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: SCRAM with channel binding downgrade attack
Next
From: Peter Eisentraut
Date:
Subject: Re: Transform for pl/perl