Re: Incorrect comment in get_partition_dispatch_recurse - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Incorrect comment in get_partition_dispatch_recurse
Date
Msg-id CA+TgmoZEAz1Mic1SUDcjNhy+RxOisKRcyPaJopQcvWdK6MqDug@mail.gmail.com
Whole thread Raw
In response to Re: Incorrect comment in get_partition_dispatch_recurse  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On Thu, May 17, 2018 at 9:56 PM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> On 2018/05/18 5:56, David Rowley wrote:
>> On 18 May 2018 at 06:21, Robert Haas <robertmhaas@gmail.com> wrote:
>>> All right, so let's just say that explicitly.  Maybe something like
>>> the attached.
>>
>> That looks fine to me.
>
> Me too, except:
>
> +        * *pds list is the root partition, so 0 always means the first leaf. When
>
> I prefer "root partitioned table" over "root partition", and git grep
> suggests that that's actually what we use elsewhere in the source code.

I don't know that it's necessary to be that rigid about this, so I
chose to commit without changing it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Built-in connection pooling
Next
From: Robert Haas
Date:
Subject: Re: Incorrect comment in get_partition_dispatch_recurse