Re: not fully correct error message - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: not fully correct error message
Date
Msg-id a15b72bb-681a-4d17-a0dc-98acc16d3db8@proxel.se
Whole thread Raw
In response to Re: not fully correct error message  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: not fully correct error message
List pgsql-hackers
On 1/3/26 7:03 PM, Tom Lane wrote:
> Andreas Karlsson <andreas@proxel.se> writes:
>> A potential third option would be to take your solution but to add a
>> HINT about that it needs to run as a top-level statement outside any
>> transactions, but I kinda liked how simple the original patch was.
> 
> Yeah, I like just adding "or procedure" and calling it good.
> I do not think we need a regression test, either ...

Yeah, let's keep it simple.

> Poking around, I also found this:
> 
> src/backend/commands/wait.c:                              errdetail("WAIT FOR cannot be executed from a function or a
procedureor within a transaction with an isolation level higher than READ COMMITTED."));
 
> 
> which is also not great grammar.  What do you think of "WAIT FOR
> cannot be executed from a function or procedure, nor within a
> transaction with an isolation level higher than READ COMMITTED." ?

Much better!

Andreas




pgsql-hackers by date:

Previous
From: Mahendra Singh Thalor
Date:
Subject: Re: Non-text mode for pg_dumpall
Next
From: Andrey Borodin
Date:
Subject: Re: GIN pageinspect support for entry tree and posting tree