Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id C26BE268-A4B2-43B7-8145-0F8E1DEFA21D@yandex-team.ru
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: GIN pageinspect support for entry tree and posting tree
List pgsql-hackers

> On 3 Jan 2026, at 00:16, Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> PFA v4 with typo fixes.

Thanks!

I think block size dependency is not a problem. There are no pageinspect tests that pass with 1Kb pages.

I have some more nits:

Meson build needs to be updated.

Documentation is on a TODO list.

+ relation_close(indexRel, AccessShareLock);
Perhaps, index_close() is what you actually wanted?

StringInfoData buf is leaked still, you can init it once and reset in the loop.

tmpTupdesc recreation worth commenting on.


Thanks!


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: not fully correct error message
Next
From: Andreas Karlsson
Date:
Subject: Re: Parallelizing startup with many databases