Re: Cleanup code related to OpenSSL <= 0.9.6 infe/be-secure-openssl.c - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Cleanup code related to OpenSSL <= 0.9.6 infe/be-secure-openssl.c
Date
Msg-id a0a6b010-13b7-fe1a-7e3c-aabe6fc11c64@2ndquadrant.com
Whole thread Raw
In response to Cleanup code related to OpenSSL <= 0.9.6 in fe/be-secure-openssl.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Cleanup code related to OpenSSL <= 0.9.6 infe/be-secure-openssl.c
List pgsql-hackers
On 2019-09-27 05:23, Michael Paquier wrote:
> While reviewing the area, I have bumped into the following bit in
> fe-secure-openssl.c and be-secure-openssl.c:
> -        /* OpenSSL 0.96 does not support X509_V_FLAG_CRL_CHECK */
> -#ifdef X509_V_FLAG_CRL_CHECK
> [...  stuff ...]
> 
> I think that this did not get removed because of the incorrect version
> number in the comment, which should have been 0.9.6 from the start.
> 
> Anyway, let's clean up this code as per the attached.  This set of
> flags indeed exists since 0.9.7.  Any thoughts or objections?

Yes, it seems OK to clean this up in master.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Attempt to consolidate reading of XLOG page
Next
From: Peter Eisentraut
Date:
Subject: Re: PostgreSQL12 and older versions of OpenSSL