Hi,
On Thu, Nov 14, 2024 at 03:31:51PM +0900, Michael Paquier wrote:
> + /*
> + * Do serialize or not this kind of stats.
> + */
> + bool to_serialize:1;
>
> Not sure that "serialize" is the best term that applies here. For
> pgstats entries, serialization refers to the matter of writing their
> entries with a "serialized" name because they have an undefined number
> when stored locally after a reload. I'd suggest to split this concept
> into its own patch, rename the flag as "write_to_file"
Yeah, also this could useful for custom statistics. So I created a dedicated
thread and a patch proposal (see [1]).
[1]: https://www.postgresql.org/message-id/Zz3skBqzBncSFIuY%40ip-10-97-1-34.eu-west-3.compute.internal
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
