Re: Restart pg_usleep when interrupted - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Restart pg_usleep when interrupted
Date
Msg-id ZrZtdpTN7nLI4L8h@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Restart pg_usleep when interrupted  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Restart pg_usleep when interrupted
List pgsql-hackers
Hi,

On Fri, Aug 09, 2024 at 02:03:55PM -0500, Nathan Bossart wrote:
> On Thu, Aug 08, 2024 at 03:01:20PM -0500, Nathan Bossart wrote:
> > Thanks.  This one looks pretty good to me, and so I plan to commit it in
> > the near future unless anyone voices concerns about the approach.
> 
> As I am preparing this for commit, I'm wondering whether it makes sense to
> name the new function vacuum_sleep() and keep it private to vacuum.c.
> Nothing about this function is terribly specific to vacuum, and it's not
> inconceivable that it might be useful elsewhere.  Perhaps we should move it
> to pgsleep.c and rename it to something to the effect of
> pg_usleep_non_interruptable().

Yeah, I had the same thought in [1], so +1.

[1]: https://www.postgresql.org/message-id/ZpDhS4nFX66ItAze%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: is_superuser versus set_config_option's parallelism check
Next
From: Abdoulaye Ba
Date:
Subject: Re: PATCH: Add hooks for pg_total_relation_size and pg_indexes_size