Re: Disallow changing slot's failover option in transaction block - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Disallow changing slot's failover option in transaction block
Date
Msg-id ZiIxuaiINsuaWuDK@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to RE: Disallow changing slot's failover option in transaction block  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
List pgsql-hackers
Hi,

On Fri, Apr 19, 2024 at 12:39:40AM +0000, Zhijie Hou (Fujitsu) wrote:
> Here is V2 patch which includes the changes for CREATE SUBSCRIPTION as
> suggested. Since we don't connect pub to alter slot when (create_slot=false)
> anymore, the restriction that disallows failover=true when connect=false is
> also removed.

Thanks!

+          specified in the subscription. When creating the slot, ensure the slot
+          property <literal>failover</literal> matches the counterpart parameter
+          of the subscription.

The slot could be created before or after the subscription is created, so I think
it needs a bit of rewording (as here it sounds like the sub is already created),
, something like?

"Always ensure the slot property <literal>failover</literal> matches the
counterpart parameter of the subscription and vice versa."

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Idea Feedback: psql \h misses -> Offers Links?
Next
From: Peter Eisentraut
Date:
Subject: Re: Support a wildcard in backtrace_functions