Re: promotion related handling in pg_sync_replication_slots() - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: promotion related handling in pg_sync_replication_slots()
Date
Msg-id Zh4f/0eRB5wxoxLS@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: promotion related handling in pg_sync_replication_slots()  (shveta malik <shveta.malik@gmail.com>)
Responses RE: promotion related handling in pg_sync_replication_slots()
List pgsql-hackers
Hi,

On Tue, Apr 16, 2024 at 10:00:04AM +0530, shveta malik wrote:
> Please find v5 addressing above comments.

Thanks!

@@ -1634,9 +1677,14 @@ SyncReplicationSlots(WalReceiverConn *wrconn)
 {
        PG_ENSURE_ERROR_CLEANUP(slotsync_failure_callback, PointerGetDatum(wrconn));
        {
+               check_flags_and_set_sync_info(InvalidPid);
+

Given the fact that if the sync worker is running it won't be possible to trigger
a manual sync with pg_sync_replication_slots(), what about also checking the 
"sync_replication_slots" value at the start of SyncReplicationSlots() and
emmit an error if sync_replication_slots is set to on? (The message could explicitly
states that it's not possible to use the function if sync_replication_slots is
set to on).

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: promotion related handling in pg_sync_replication_slots()
Next
From: Robins Tharakan
Date:
Subject: Re: Why is parula failing?