Re: Remove a FIXME and unused variables in Meson - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove a FIXME and unused variables in Meson
Date
Msg-id ZfKIBtOH63tvI09G@paquier.xyz
Whole thread Raw
In response to Remove a FIXME and unused variables in Meson  ("Tristan Partin" <tristan@neon.tech>)
Responses Re: Remove a FIXME and unused variables in Meson
List pgsql-hackers
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
> One of them adds version gates to two LLVM flags (-frwapv,
> -fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
> so these might not be necessary, but maybe it helps for historictal reasons.
> If not, I'll just remove the comment in a different patch.
>
> Second patch removes some unused variables. Were they analogous to things in
> autotools and the Meson portions haven't been added yet?
>
> I was looking into adding LLVM JIT support to Meson since there is a TODO
> about it, but it wasn't clear what was missing except adding some variables
> into the PGXS Makefile.

It looks like you have forgotten to attach the patches.  :)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Remove a FIXME and unused variables in Meson
Next
From: "Tristan Partin"
Date:
Subject: Re: Remove a FIXME and unused variables in Meson