Re: Remove a FIXME and unused variables in Meson - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: Remove a FIXME and unused variables in Meson
Date
Msg-id CZT7V7VCDQG9.3BVU68NHJB0X3@neon.tech
Whole thread Raw
In response to Re: Remove a FIXME and unused variables in Meson  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu Mar 14, 2024 at 12:15 AM CDT, Michael Paquier wrote:
> On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
> > One of them adds version gates to two LLVM flags (-frwapv,
> > -fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
> > so these might not be necessary, but maybe it helps for historictal reasons.
> > If not, I'll just remove the comment in a different patch.
> >
> > Second patch removes some unused variables. Were they analogous to things in
> > autotools and the Meson portions haven't been added yet?
> >
> > I was looking into adding LLVM JIT support to Meson since there is a TODO
> > about it, but it wasn't clear what was missing except adding some variables
> > into the PGXS Makefile.
>
> It looks like you have forgotten to attach the patches.  :)

CLASSIC!

--
Tristan Partin
Neon (https://neon.tech)

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove a FIXME and unused variables in Meson
Next
From: Ashutosh Bapat
Date:
Subject: Re: pg16: XX000: could not find pathkey item to sort