Re: SSL tests fail on OpenSSL v3.2.0 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: SSL tests fail on OpenSSL v3.2.0
Date
Msg-id ZWUsCSbEFU5G_FYN@paquier.xyz
Whole thread Raw
In response to Re: SSL tests fail on OpenSSL v3.2.0  ("Tristan Partin" <tristan@neon.tech>)
Responses Re: SSL tests fail on OpenSSL v3.2.0  ("Tristan Partin" <tristan@neon.tech>)
Re: SSL tests fail on OpenSSL v3.2.0  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Nov 27, 2023 at 12:33:49PM -0600, Tristan Partin wrote:
> -        res = secure_raw_read(((Port *) BIO_get_data(h)), buf, size);
> +        res = secure_raw_read(((Port *) BIO_get_app_data(h)), buf, size);
>          BIO_clear_retry_flags(h);
>          if (res <= 0)

Interesting.  I have yet to look at that in details, but
BIO_get_app_data() exists down to 0.9.8, which is the oldest version
we need to support for stable branches.  So that looks like a safe
bet.

> -#ifndef HAVE_BIO_GET_DATA
> -#define BIO_get_data(bio) (bio->ptr)
> -#define BIO_set_data(bio, data) (bio->ptr = data)
> -#endif

Shouldn't this patch do a refresh of configure.ac and remove the check
on BIO_get_data() if HAVE_BIO_GET_DATA is gone?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Partial aggregates pushdown
Next
From: "Tristan Partin"
Date:
Subject: Re: SSL tests fail on OpenSSL v3.2.0