Re: SSL tests fail on OpenSSL v3.2.0 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SSL tests fail on OpenSSL v3.2.0
Date
Msg-id 4036729.1701130863@sss.pgh.pa.us
Whole thread Raw
In response to Re: SSL tests fail on OpenSSL v3.2.0  (Michael Paquier <michael@paquier.xyz>)
Responses Re: SSL tests fail on OpenSSL v3.2.0
Re: SSL tests fail on OpenSSL v3.2.0
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> Interesting.  I have yet to look at that in details, but
> BIO_get_app_data() exists down to 0.9.8, which is the oldest version
> we need to support for stable branches.  So that looks like a safe
> bet.

What about LibreSSL?  In general, I'm not too pleased with just assuming
that BIO_get_app_data exists.  If we can do that, we can probably remove
most of the OpenSSL function probes that configure.ac has today.  Even
if that's a good idea in HEAD, I doubt we want to do it all the way back.

I'd be inclined to form the patch more along the lines of
s/BIO_get_data/BIO_get_app_data/g, with a configure check for
BIO_get_app_data and falling back to the existing direct use of
bio->ptr if it's not there.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: POC, WIP: OR-clause support for indexes
Next
From: Bo Anderson
Date:
Subject: Re: SSL tests fail on OpenSSL v3.2.0