Re: Typo with amtype = 's' in opr_sanity.sql - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Typo with amtype = 's' in opr_sanity.sql
Date
Msg-id ZV1MkCIf4zI0ilJU@paquier.xyz
Whole thread Raw
In response to Re: Typo with amtype = 's' in opr_sanity.sql  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
On Tue, Nov 21, 2023 at 01:02:40PM +0300, Aleksander Alekseev wrote:
>> It seems to me that this has been copy-pasted on HEAD from the
>> sequence AM patch, but forgot to update amtype to 't'.  While that's
>> maybe cosmetic, I think that this could lead to unexpected results, so
>> perhaps there is a point in doing a backpatch?
>
> I disagree that it's cosmetic. The test doesn't check what it's supposed to.

Yes, I've backpatched that all the way down to 12 at the end.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] legitimacy of using PG_TRY , PG_CATCH , PG_END_TRY in C function
Next
From: Peter Smith
Date:
Subject: Re: pg_upgrade and logical replication