Re: Remove io prefix from pg_stat_io columns - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove io prefix from pg_stat_io columns
Date
Msg-id ZECRoDDbYP7p794F@paquier.xyz
Whole thread Raw
In response to Re: Remove io prefix from pg_stat_io columns  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: Remove io prefix from pg_stat_io columns
Re: Remove io prefix from pg_stat_io columns
List pgsql-hackers
On Wed, Apr 19, 2023 at 08:50:13PM -0400, Melanie Plageman wrote:
> I thought about changing parameter and local variable names to remove
> the prefix, but in the original discussion folks seemed to think it made
> sense to leave the "C level" references with an "io" prefix. I think we
> could change many of them, but some of them may be required for clarity.

I agree with the feeling of not touching the internal variables.  It
makes them easier to grep, and it seems that these are mostly on lines
where there is little context about what they refer to..

Perhaps others have comments or objections, so let's wait a bit, but
I'd be OK to apply this one myself, with a catversion bump.  (Happy to
help.)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Autogenerate some wait events code and documentation
Next
From: Thomas Munro
Date:
Subject: Re: check_strxfrm_bug()