Re: [PATCH] Optionally record Plan IDs to track plan changes for a query - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Optionally record Plan IDs to track plan changes for a query
Date
Msg-id Z9khOo14yzZHCnmn@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Optionally record Plan IDs to track plan changes for a query  (Sami Imseih <samimseih@gmail.com>)
Responses Re: [PATCH] Optionally record Plan IDs to track plan changes for a query
List pgsql-hackers
On Thu, Feb 13, 2025 at 10:44:33AM -0600, Sami Imseih wrote:
> The reason for the change is because "query jumble" will no longer
> make sense if the jumble code can now be used for other types of
> trees, such as Plan.
>
> I do agree that this needs a single-threaded discussion to achieve a
> consensus.

FWIW, I was playing with a sub-project where I was jumbling a portion
of nodes other than Query, and it is annoying to not have a direct
access to jumbleNode().  So, how about doing the refactoring proposed
in v5-0002 with an initialization routine and JumbleNode() as the
entry point for the jumbling, but not rename the existing files
queryjumblefuncs.c and queryjumble.h?  That seems doable for this
release, at least.

I don't think that we should expose AppendJumble(), either.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Some read stream improvements
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: pg_recvlogical requires -d but not described on the documentation