Re: Log connection establishment timings - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Log connection establishment timings
Date
Msg-id Z8gQ+3jLa6qUu5E7@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Log connection establishment timings  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
Hi,

On Tue, Mar 04, 2025 at 05:47:26PM -0500, Melanie Plageman wrote:
> On Mon, Mar 3, 2025 at 9:07 AM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> >
> > I did not imagine that much ;-) I was just seeing this code being duplicated
> > and just thought about to avoid the duplication. But now that I read your comments
> > above then I think we could just macro-ize the child_type check (as you mentioned
> > up-thread). That would avoid the risk to forget to update the 3 locations doing the
> > exact same check should we add a new child type in the game.
> 
> Is there a word we could use to describe what B_BACKEND and
> B_WAL_SENDER have in common? They are the only backend types that will
> go through the kind of external connection establishment steps (I
> think), but I don't know a very accurate way to make that distinction
> (which is required to come up with a useful macro name).

Yeah, what about IS_CONNECTION_TIMED_BACKEND?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Separate GUC for replication origins
Next
From: Heikki Linnakangas
Date:
Subject: Re: Why doesn't GiST VACUUM require a super-exclusive lock, like nbtree VACUUM?