On Wed, Jan 22, 2025 at 10:58:09AM +0000, Chiranmoy.Bhattacharya@fujitsu.com wrote:
>> The functions that test the length before potentially calling a function
>> pointer should probably be inlined (see pg_popcount() in pg_bitutils.h).
>> I wouldn't be surprised if some compilers are inlining this stuff
>> already, but it's probably worth being explicit about it.
>
> Should we implement an inline function in "utils/builtins.h", similar to
> pg_popcount()? Currently, we have not modified the header file, everything
> is statically implemented in encode.c.
Yeah, that's what I'm currently thinking we should do.
--
nathan
