Re: Proposal: add new API to stringinfo - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Proposal: add new API to stringinfo
Date
Msg-id Z366uV4ujXT6ioCV@nathan
Whole thread Raw
In response to Re: Proposal: add new API to stringinfo  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Tue, Jan 07, 2025 at 03:57:57PM +0900, Tatsuo Ishii wrote:
> So the v2 patch version is 1.3787% slower than master. Do you think we
> need further inlining?

If it's not too much work to coax the compiler to do so, then I don't see a
strong reason to avoid it.  Granted, there are probably much more expensive
parts of the StringInfo support functions (e.g., palloc()), but these are
hot enough code paths that IMHO it's worth saving whatever cycles we can.

-- 
nathan



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Fwd: Re: A new look at old NFS readdir() problems?
Next
From: Nathan Bossart
Date:
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64