Re: Track the amount of time waiting due to cost_delay - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Track the amount of time waiting due to cost_delay
Date
Msg-id Z2CjkOdOC0tBCbsu@nathan
Whole thread Raw
In response to Re: Track the amount of time waiting due to cost_delay  (Dilip Kumar <dilipbalaut@gmail.com>)
List pgsql-hackers
On Mon, Dec 16, 2024 at 10:11:23AM +0000, Bertrand Drouvot wrote:
> +#define PARALLEL_VACUUM_WORKER_DELAY_REPORT_INTERVAL_NS (NS_PER_S)
> 
> Did not changed in v14, but "PARALLEL_VACUUM_REPORT_INTERVAL_NS" could be
> an option as well. I think it keeps the key concepts while being more concise (
> WORKER is somehow implicit in the context).

I think it's important to keep "delay" somewhere in the name, so how about
PARALLEL_VACUUM_DELAY_REPORT_INTERVAL_NS?

> -vacuum_delay_point(void)
> +static void
> +vacuum_delay_point_internal(bool is_analyze)
> 
> Updated the comment on top of it accordingly.

Thanks.  I think we need to do some additional adjustments to this
commentary since external callers should now use
vacuum/analyze_delay_point().

-- 
nathan



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: A few patches to clarify snapshot management
Next
From: Tom Lane
Date:
Subject: Re: Support regular expressions with nondeterministic collations