Re: Proposal for Updating CRC32C with AVX-512 Algorithm. - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Proposal for Updating CRC32C with AVX-512 Algorithm.
Date
Msg-id Z0-OD2P_Sw9T7dQ-@nathan
Whole thread Raw
In response to RE: Proposal for Updating CRC32C with AVX-512 Algorithm.  ("Amonson, Paul D" <paul.d.amonson@intel.com>)
Responses RE: Proposal for Updating CRC32C with AVX-512 Algorithm.
List pgsql-hackers
On Tue, Dec 03, 2024 at 03:46:16PM +0000, Devulapalli, Raghuveer wrote:
>> Raghuveer, would you mind rebasing this patch set now that the SSE4.2 patch is
>> committed?
> 
> Rebased to master branch. 

Thanks!  cfbot is showing a couple of errors [0] [1] [2].  32-bit Linux is
failing to compile with the 64-bit intrinsics.  I think it'd be fine to
limi this optimization to 64-bit builds unless the code can be easily fixed
to work for both.  The macOS build seems to be trying to include the x86
headers, which is producing many errors.  We'll need to make sure that none
of this code is being compiled on ARM machine.  The Windows build seems to
be unable to resolve the pg_comp_crc32c symbol, but it is not immediately
obvious to me why.

[0] https://cirrus-ci.com/task/6023394207989760
[1] https://cirrus-ci.com/task/5460444254568448
[2] https://cirrus-ci.com/task/6586344161411072

-- 
nathan



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)
Next
From: John Naylor
Date:
Subject: Re: CRC32C Parallel Computation Optimization on ARM